cyb70289 commented on a change in pull request #11674:
URL: https://github.com/apache/arrow/pull/11674#discussion_r749000618
##########
File path: cpp/src/arrow/util/bitmap_ops.cc
##########
@@ -311,39 +345,49 @@ Result<std::shared_ptr<Buffer>> BitmapAnd(MemoryPool*
pool, const uint8_t* left,
int64_t left_offset, const uint8_t*
right,
int64_t right_offset, int64_t length,
int64_t out_offset) {
+ // TODO(pradeep) Figure out the return type for this version of BitmapOps
+ int64_t out_pop_count = 0;
return BitmapOp<std::bit_and>(pool, left, left_offset, right, right_offset,
length,
- out_offset);
+ out_offset, &out_pop_count);
Review comment:
I think we can make the api same as the void func. Adding an output
int64 argument with default value nullptr is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
