acrites commented on a change in pull request #11993:
URL: https://github.com/apache/beam/pull/11993#discussion_r444339102
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3808,15 +3817,24 @@ public void onTimer(
TestStream<KV<String, Integer>> stream =
TestStream.create(KvCoder.of(StringUtf8Coder.of(), VarIntCoder.of()))
// See GlobalWindow,
- // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1))
-
.advanceWatermarkTo(BoundedWindow.TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)))
+ // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)),
Review comment:
Yichi and I played around with some flag settings in Dataflow and I
think we can change the time resolution for tests to milliseconds, which should
make this test pass. However, I'm a little worried in that we then aren't
testing the same as prod, so we might end up missing some other bugs that come
up.
Otherwise, I don't really know a good way around this since
`BoundedWindow.TIMESTAMP_MAX_VALUE` is not a round number of seconds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
