lukecwik commented on a change in pull request #11993:
URL: https://github.com/apache/beam/pull/11993#discussion_r445817767
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3808,15 +3817,24 @@ public void onTimer(
TestStream<KV<String, Integer>> stream =
TestStream.create(KvCoder.of(StringUtf8Coder.of(), VarIntCoder.of()))
// See GlobalWindow,
- // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1))
-
.advanceWatermarkTo(BoundedWindow.TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)))
+ // END_OF_GLOBAL_WINDOW is
TIMESTAMP_MAX_VALUE.minus(Duration.standardDays(1)),
Review comment:
Lets leave this one tests as is and remove it from the change. We can
update the others with the changes since they won't change the semantics of
what is being tested.
For Dataflow's TestStream implementation, to simulate production, it should
round all the advance timestampts to the closest `>=` internal timestamp. It
should also make sure that no two advance timestamps that aren't the same are
not rounded to the same value. I believe this would make this test work and it
would simulate what is happening in production.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
