camphillips22 commented on code in PR #24307:
URL: https://github.com/apache/beam/pull/24307#discussion_r1030616603
##########
sdks/go/pkg/beam/core/graph/coder/coder.go:
##########
@@ -177,6 +177,7 @@ const (
Iterable Kind = "I"
KV Kind = "KV"
LP Kind = "LP" // Explicitly length prefixed, likely at
the runner's direction.
+ IWCValue Kind = "IWCvalue"
Review Comment:
I had named it `IntervalWindow` to start, but there's a conflicting
`IntervalWindow` value define
[here](https://github.com/camphillips22/beam/blob/c83b42f7547a5fd57e2f9a90d7b613c512eb088c/sdks/go/pkg/beam/core/graph/coder/windows.go#L25-L25).
Maybe just `IW` for const name with a comment that explicitly calls out that
it refers to an `IntervalWindow`? Any other suggestions?
I can definitely change the value to "IW" though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
