camphillips22 commented on code in PR #24307:
URL: https://github.com/apache/beam/pull/24307#discussion_r1030686917
##########
sdks/go/pkg/beam/core/runtime/graphx/coder.go:
##########
@@ -245,6 +245,10 @@ func (b *CoderUnmarshaller) makeCoder(id string, c
*pipepb.Coder) (*coder.Coder,
t := typex.New(root,
append([]typex.FullType{key.T}, coder.Types(values)...)...)
return &coder.Coder{Kind: kind, T: t,
Components: append([]*coder.Coder{key}, values...)}, nil
}
+ case urnIntervalWindow:
+ // If interval window in a KV, this may be a mapping
function.
+ // Special case since windows are not normally used
directly as FullValues.
+ return coder.NewIntervalWindowCoder(), nil
Review Comment:
> It'd be better if we follow the normal structure, generalizing to handle
interval windows better instead of special casing here.
To clarify, are you suggesting that we need to pull this special case out of
the KV coder case, or just to return an actual KV coder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
