lostluck commented on code in PR #24307:
URL: https://github.com/apache/beam/pull/24307#discussion_r1030957657
##########
sdks/go/pkg/beam/core/runtime/graphx/coder.go:
##########
@@ -379,18 +379,14 @@ func (b *CoderUnmarshaller) makeCoder(id string, c
*pipepb.Coder) (*coder.Coder,
return nil, err
}
return coder.NewN(elm), nil
-
- // Special handling for window coders so they can be treated as
- // a general coder. Generally window coders are not used
outside of
- // specific contexts, but this enables improved testing.
- // Window types are not permitted to be fulltypes, so
- // we use assignably equivalent anonymous struct types.
case urnIntervalWindow:
Review Comment:
I think that's the only remaining thing for me to block on before merging.
Also, FYI, my foretold change: #24346
At this point I'll handle the merge conflict instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
