lostluck commented on code in PR #24307:
URL: https://github.com/apache/beam/pull/24307#discussion_r1030741894
##########
sdks/go/pkg/beam/core/runtime/graphx/coder.go:
##########
@@ -248,7 +248,9 @@ func (b *CoderUnmarshaller) makeCoder(id string, c
*pipepb.Coder) (*coder.Coder,
case urnIntervalWindow:
// If interval window in a KV, this may be a mapping
function.
// Special case since windows are not normally used
directly as FullValues.
- return coder.NewIntervalWindowCoder(), nil
+ value := coder.NewIntervalWindowCoder()
+ t := typex.New(root, key.T, value.T)
+ return &coder.Coder{Kind: kind, T: t, Components:
[]*coder.Coder{key, value}}, nil
Review Comment:
As the person who put that in, I'd rather inconvenience the tests than the
production code. Please feel free to change them up. (sorry for the churn).
That was before I was aware that there were uses for runner sending coders
around like that, and we just wanted to validate the coders per the
standard_coders.yaml tests.
Those uses are handled here usually:
https://github.com/camphillips22/beam/tree/c83b42f7547a5fd57e2f9a90d7b613c512eb088c/sdks/go/test/regression/coders/fromyaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
