camphillips22 commented on code in PR #24307:
URL: https://github.com/apache/beam/pull/24307#discussion_r1030725742
##########
sdks/go/pkg/beam/core/runtime/graphx/coder.go:
##########
@@ -248,7 +248,9 @@ func (b *CoderUnmarshaller) makeCoder(id string, c
*pipepb.Coder) (*coder.Coder,
case urnIntervalWindow:
// If interval window in a KV, this may be a mapping
function.
// Special case since windows are not normally used
directly as FullValues.
- return coder.NewIntervalWindowCoder(), nil
+ value := coder.NewIntervalWindowCoder()
+ t := typex.New(root, key.T, value.T)
+ return &coder.Coder{Kind: kind, T: t, Components:
[]*coder.Coder{key, value}}, nil
Review Comment:
Ah, so there is already a case in the switch for that
[here](https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/graphx/coder.go#L388-L393),
and it talks about special handling for tests. I was hesitant to do anything
with that before review. It also looks like there's other behavior that might
depend on that being a `Window` coder instead of this new kind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
