je-ik commented on code in PR #30403:
URL: https://github.com/apache/beam/pull/30403#discussion_r1501221936
##########
runners/core-java/build.gradle:
##########
@@ -46,6 +46,8 @@ dependencies {
implementation library.java.joda_time
implementation library.java.vendored_grpc_1_60_1
implementation library.java.slf4j_api
+ implementation library.java.jackson_core
+ implementation library.java.jackson_databind
Review Comment:
@robertwb this is unfortunate. Do we have a check for API surface that this
does not leak anywhere? In old construction-java and in sdk-core this is
shaded. I can shade it, but runners-core is currently "plain", so that could be
argument against placing it into the runners-core. I'm not familar enough wth
the details of the build system to make a decision myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
