je-ik commented on code in PR #30403: URL: https://github.com/apache/beam/pull/30403#discussion_r1502970165
########## runners/spark/3/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/SparkSessionFactory.java: ########## @@ -29,6 +29,7 @@ import java.util.HashMap; import javax.annotation.Nullable; import org.apache.beam.repackaged.core.org.apache.commons.lang3.ArrayUtils; +import org.apache.beam.runners.core.construction.SerializablePipelineOptions; Review Comment: Ah, sorry, I forgot. The discusson with @robertwb was that we will remove SerializablePipelineOptions from sdks-java-core completely. That is why the packages changed in all affected runners. Actually, I think that is correct, because of the potential serializability issue. The SerializablePipelineOptions is intended for runners, so runners-core-java might be actually the correct place to put it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
