je-ik commented on code in PR #30403:
URL: https://github.com/apache/beam/pull/30403#discussion_r1502178358


##########
runners/core-java/build.gradle:
##########
@@ -46,6 +46,8 @@ dependencies {
   implementation library.java.joda_time
   implementation library.java.vendored_grpc_1_60_1
   implementation library.java.slf4j_api
+  implementation library.java.jackson_core
+  implementation library.java.jackson_databind

Review Comment:
   The `shadow` configuration apparently means the opposite than I would 
expect. sdks-java-core already has jackson as a runtime dependecny, thus this 
only fixes checkstyle to not to complain on undeclared transitive dependency. 
Should be safe to merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to