robertwb commented on code in PR #30403: URL: https://github.com/apache/beam/pull/30403#discussion_r1502983116
########## runners/spark/3/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/SparkSessionFactory.java: ########## @@ -29,6 +29,7 @@ import java.util.HashMap; import javax.annotation.Nullable; import org.apache.beam.repackaged.core.org.apache.commons.lang3.ArrayUtils; +import org.apache.beam.runners.core.construction.SerializablePipelineOptions; Review Comment: Yes. SerializablePipelineOptions (per its name) is presumably intended for serialization, so it would be backwards incompatible to move it. Fortunately it's only referenced by runners, so probably makes sense as part of a runner support package. I agree further cleanup could be done here, but that would require resolving the shading/jackson issues too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
