kennknowles commented on code in PR #30403: URL: https://github.com/apache/beam/pull/30403#discussion_r1502956290
########## runners/core-java/src/main/java/org/apache/beam/runners/core/construction/SerializablePipelineOptions.java: ########## @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.beam.sdk.util.construction; +package org.apache.beam.runners.core.construction; Review Comment: What about just re-introduce this to the flink runner? Yes the package doesn't match but at least it is isolated and not where anyone else might use it. ########## runners/spark/3/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/SparkSessionFactory.java: ########## @@ -29,6 +29,7 @@ import java.util.HashMap; import javax.annotation.Nullable; import org.apache.beam.repackaged.core.org.apache.commons.lang3.ArrayUtils; +import org.apache.beam.runners.core.construction.SerializablePipelineOptions; Review Comment: ugh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
