damccorm commented on code in PR #34348:
URL: https://github.com/apache/beam/pull/34348#discussion_r2037800089
##########
sdks/go/pkg/beam/runners/prism/internal/urns/urns.go:
##########
@@ -124,6 +124,7 @@ var (
CoderTimer = cdrUrn(pipepb.StandardCoders_TIMER)
CoderKV = cdrUrn(pipepb.StandardCoders_KV)
+ CoderTuple = "beam:coder:tuple:v1"
Review Comment:
My take for moving forward here is that we have 2 options:
1) Take this PR more or less as-is. Maybe file an issue for fixing the coder
in a different way.
2) Revert the prism changes, file an issue for fixing the coder the right
way (which seems like more work), and sickbay the test
I think we should go with option (1) - @lostluck does that seem reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
