damccorm commented on code in PR #34348:
URL: https://github.com/apache/beam/pull/34348#discussion_r2037960186
##########
sdks/go/pkg/beam/runners/prism/internal/urns/urns.go:
##########
@@ -124,6 +124,7 @@ var (
CoderTimer = cdrUrn(pipepb.StandardCoders_TIMER)
CoderKV = cdrUrn(pipepb.StandardCoders_KV)
+ CoderTuple = "beam:coder:tuple:v1"
Review Comment:
Sorry, long thread and it was not clear to me that you were recommending
away from this approach (I got a little lost in the tradeoffs as I was trying
to find a path forward). I reread the thread and I think I now understand the
concerns. I think it is fair to not want to special case this.
@claudevdm I'd probably recommend:
1) Try the fix rebo suggested in
https://github.com/apache/beam/pull/34348#discussion_r2021658318
2) If it works with not a ton of work, we can take that forward
3) If it turns into significant work, we can sickbay the test on prism for
now and follow up on https://github.com/apache/beam/issues/32636 independently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
