lostluck commented on code in PR #34348:
URL: https://github.com/apache/beam/pull/34348#discussion_r2037894272
##########
sdks/go/pkg/beam/runners/prism/internal/urns/urns.go:
##########
@@ -124,6 +124,7 @@ var (
CoderTimer = cdrUrn(pipepb.StandardCoders_TIMER)
CoderKV = cdrUrn(pipepb.StandardCoders_KV)
+ CoderTuple = "beam:coder:tuple:v1"
Review Comment:
I have a strong preference to not put in references to non-model coders into
Prism. It sets a poror precedent and will cause additional maintenance burdens
down the road.
So, no, it doesn't seem reasonable to start down that road when there's a
known alternative solution.
My vote remains to do what I've already suggested last week which isn't very
much work.
##########
sdks/go/pkg/beam/runners/prism/internal/urns/urns.go:
##########
@@ -124,6 +124,7 @@ var (
CoderTimer = cdrUrn(pipepb.StandardCoders_TIMER)
CoderKV = cdrUrn(pipepb.StandardCoders_KV)
+ CoderTuple = "beam:coder:tuple:v1"
Review Comment:
I have a strong preference to not put in references to non-model coders into
Prism. It sets a poor precedent and will cause additional maintenance burdens
down the road.
So, no, it doesn't seem reasonable to start down that road when there's a
known alternative solution.
My vote remains to do what I've already suggested last week which isn't very
much work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
