shunping commented on code in PR #34348:
URL: https://github.com/apache/beam/pull/34348#discussion_r2035896734
##########
sdks/go/pkg/beam/runners/prism/internal/urns/urns.go:
##########
@@ -124,6 +124,7 @@ var (
CoderTimer = cdrUrn(pipepb.StandardCoders_TIMER)
CoderKV = cdrUrn(pipepb.StandardCoders_KV)
+ CoderTuple = "beam:coder:tuple:v1"
Review Comment:
@lostluck
Regarding the option 2 you mentioned:
> 2 We are forced to specify known composite coders to avoid Length
Prefixing them unnecessarily.
So instead of just the set of Known Leaf Coders, we would have the set of
Known Composite Coders, that don't need length prefixing. Anything else should
just be length prefixed.
I think if I understand correctly, we should LP this tuple coder with urn
"beam:coder:tuple:v1". In that case, we will need to come up with a list of
"known composite" which excludes "beam:codeR:tuple:v1". Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
