damccorm commented on code in PR #35263:
URL: https://github.com/apache/beam/pull/35263#discussion_r2152294890
##########
sdks/go/pkg/beam/runners/prism/internal/stage.go:
##########
@@ -194,7 +194,8 @@ progress:
case resp = <-b.Resp:
bundleFinished = true
if b.BundleErr != nil {
- return b.BundleErr
+ // return b.BundleErr
+ panic("this should get triggered")
Review Comment:
It took 16 jobs, but eventually the panic in bundle.go didn't fire either.
This is interesting because it fails much more consistently when we panic here
https://github.com/apache/beam/blob/679477947395746be01f9d1639283afd22d3d3a1/sdks/go/pkg/beam/runners/prism/internal/stage.go#L196-L198
than when we panic here
https://github.com/apache/beam/blob/e5e07c5100c0fdfdc6f864ee7b9fd69b04f6f51c/sdks/go/pkg/beam/runners/prism/internal/worker/bundle.go#L105-109
My current theory is that somehow in the stage execution loop, we're
breaking before receiving the actual instruction response
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
