lostluck commented on code in PR #35263:
URL: https://github.com/apache/beam/pull/35263#discussion_r2152352589
##########
sdks/go/pkg/beam/runners/prism/internal/stage.go:
##########
@@ -194,7 +194,8 @@ progress:
case resp = <-b.Resp:
bundleFinished = true
if b.BundleErr != nil {
- return b.BundleErr
+ // return b.BundleErr
+ panic("this should get triggered")
Review Comment:
That's tricky. Since that should only happen if the SDK worker environment
is coming down, which causes the job to start cancelling.
The expectation is we won't be getting an RPC response for a bundle if it's
worker has shut down.
Of we confirm that's the issue we might be able to mitigate with a sleep
along the worker shutdown path that cancels the context.
(internal/environment.go IIRC). If it's still flaky after that, it's something
that needs to be arranged Python side rather than Prism side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
