damccorm commented on code in PR #35263:
URL: https://github.com/apache/beam/pull/35263#discussion_r2152753886
##########
sdks/go/pkg/beam/runners/prism/internal/stage.go:
##########
@@ -194,7 +194,8 @@ progress:
case resp = <-b.Resp:
bundleFinished = true
if b.BundleErr != nil {
- return b.BundleErr
+ // return b.BundleErr
+ panic("this should get triggered")
Review Comment:
Interestingly
https://github.com/apache/beam/pull/35263/commits/9eaebbc81feef3ca2303ce7dafef1175338e4b0a
causes the job to panic (correctly) 100% of the time (over 8 runs).
But
https://github.com/apache/beam/pull/35263/commits/837db22bc4c7c61dd5857be9a70a1c0a66f947c8
only causes the job to panic (correctly) some of the time (3/4 runs).
While
https://github.com/apache/beam/pull/35263/commits/cbc2d2f6e766757fa1c85816112f0dab8a55b47c
causes the job to panic (correctly) almost all of the time (16/16 runs), but
not quite always.
My current theory is that we're sometimes breaking either here:
https://github.com/apache/beam/blob/2e956263496564a614d216b7f985fa5a793baad7/sdks/go/pkg/beam/runners/prism/internal/stage.go#L210-L213
or here
https://github.com/apache/beam/blob/2e956263496564a614d216b7f985fa5a793baad7/sdks/go/pkg/beam/runners/prism/internal/stage.go#L226-L229
but those don't cause errors. I'm not sure what the correct behavior is, but
it seems like we should probably either be continuing or throwing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
