damccorm commented on code in PR #35263:
URL: https://github.com/apache/beam/pull/35263#discussion_r2152934455
##########
sdks/go/pkg/beam/runners/prism/internal/stage.go:
##########
@@ -194,7 +194,8 @@ progress:
case resp = <-b.Resp:
bundleFinished = true
if b.BundleErr != nil {
- return b.BundleErr
+ // return b.BundleErr
+ panic("this should get triggered")
Review Comment:
I created a PR for this here - https://github.com/apache/beam/pull/35337 -
and plan to move any discussion about the correctness (or lack thereof) of this
proposed change to that PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
