damccorm commented on code in PR #35263:
URL: https://github.com/apache/beam/pull/35263#discussion_r2152907761
##########
sdks/go/pkg/beam/runners/prism/internal/stage.go:
##########
@@ -194,7 +194,8 @@ progress:
case resp = <-b.Resp:
bundleFinished = true
if b.BundleErr != nil {
- return b.BundleErr
+ // return b.BundleErr
+ panic("this should get triggered")
Review Comment:
Yeah, I'm reasonably confident this is the issue now. I tried
https://github.com/apache/beam/pull/35263/commits/5d9485809525127ff326c7b1edd3c31a20dcf6b8
and now all the jobs (correctly) failed, but one failed with an unexpected
error message
([job](https://github.com/apache/beam/actions/runs/15714257629/job/44279977547?pr=35263)):
```
File
"/runner/_work/beam/beam/sdks/python/test-suites/tox/py39/build/srcs/sdks/python/target/.tox-py39-cloud/py39-cloud/lib/python3.9/site-packages/apache_beam/runners/worker/sdk_worker.py",
line 723, in process_bundle_split
processor = self.bundle_processor_cache.lookup(request.instruction_id)
File
"/runner/_work/beam/beam/sdks/python/test-suites/tox/py39/build/srcs/sdks/python/target/.tox-py39-cloud/py39-cloud/lib/python3.9/site-packages/apache_beam/runners/worker/sdk_worker.py",
line 540, in lookup
raise RuntimeError(
RuntimeError: Bundle processing associated with inst002 has failed. Check
prior failing response for details.
```
So this means that this section is getting exercised:
https://github.com/apache/beam/blob/2e956263496564a614d216b7f985fa5a793baad7/sdks/go/pkg/beam/runners/prism/internal/stage.go#L225-L229
which is breaking out of the execution loop. There's no special handling of
this, so ultimately we return a healthy response from bundle processing
https://github.com/apache/beam/blob/2e956263496564a614d216b7f985fa5a793baad7/sdks/go/pkg/beam/runners/prism/internal/stage.go#L343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
