kennknowles commented on code in PR #38454:
URL: https://github.com/apache/beam/pull/38454#discussion_r3348754626
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/LateDataDroppingDoFnRunner.java:
##########
@@ -101,6 +101,11 @@ public void finishBundle() {
doFnRunner.finishBundle();
}
+ @Override
+ public void finishKey() {
Review Comment:
This method adds a presumption that the DoFnRunner tracks a current key.
This is not generally required. See how the other methods pass the key in
explicitly. What would be the impact of doing that? For a runner where the key
is already known, it is easy enough to just ignore the parameter. (or it could
be a useful way to avoid errors/assumptions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
