arunpandianp commented on code in PR #38454:
URL: https://github.com/apache/beam/pull/38454#discussion_r3358214332
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java:
##########
@@ -231,7 +231,7 @@ public void finishBundle() {
}
@Override
- public void finishKey() {}
+ public <KeyT extends @Nullable Object> void finishKey(KeyT key) {}
Review Comment:
Since KeyT is a method level template and we don't use KeyT anywhere else in
the method yet, changing to `finishKey(@Nullable Object key)` is an option. do
you think that is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
