arunpandianp commented on code in PR #38454:
URL: https://github.com/apache/beam/pull/38454#discussion_r3358123749
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java:
##########
@@ -231,7 +231,7 @@ public void finishBundle() {
}
@Override
- public void finishKey() {}
+ public <KeyT extends @Nullable Object> void finishKey(KeyT key) {}
Review Comment:
There can be stages where there is no key/keycoder and we use `null` as the
key for them. Is there a different way to say key can be null here?
https://github.com/apache/beam/blob/c01ceeab24c7cae7167dbc08b21529339659094f/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java#L400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
