kennknowles commented on a change in pull request #14718:
URL: https://github.com/apache/beam/pull/14718#discussion_r630459015
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
##########
@@ -1219,11 +1219,11 @@ private void setAndVerifyOutputTimestamp() {
Instant windowExpiry = window.maxTimestamp().plus(allowedLateness);
if (TimeDomain.EVENT_TIME.equals(spec.getTimeDomain())) {
checkArgument(
- !outputTimestamp.isAfter(target),
+ !outputTimestamp.isAfter(windowExpiry),
Review comment:
Actually now that I think about it, the output timestamp really should
be before the end of the window. That is a requirement on `WindowFn.assign` and
other timestamp adjusting methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
