kennknowles commented on a change in pull request #14718:
URL: https://github.com/apache/beam/pull/14718#discussion_r630459488
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
##########
@@ -1219,11 +1219,11 @@ private void setAndVerifyOutputTimestamp() {
Instant windowExpiry = window.maxTimestamp().plus(allowedLateness);
if (TimeDomain.EVENT_TIME.equals(spec.getTimeDomain())) {
checkArgument(
- !outputTimestamp.isAfter(target),
+ !outputTimestamp.isAfter(windowExpiry),
"Attempted to set an event-time timer with an output timestamp of
%s that is"
- + " after the timer firing timestamp %s",
+ + " after the expiration of window %s",
outputTimestamp,
- target);
+ windowExpiry);
checkArgument(
!target.isAfter(windowExpiry),
Review comment:
This check is right: you shouldn't set an event time timer to fire after
expiry, because it would be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
