alamb commented on code in PR #20282:
URL: https://github.com/apache/datafusion/pull/20282#discussion_r2793986520
##########
.github/workflows/extended.yml:
##########
@@ -167,11 +167,18 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
+ - name: Build sqllogictest binary
+ run: |
+ TEST_BIN=$(cargo test --features backtrace,parquet_encryption
--profile release-nonlto --test sqllogictests --no-run --message-format=json |
sed -n 's/.*"executable":"\([^"]*\)".*/\1/p' | head -n 1)
Review Comment:
Rather than `cargo test` another idea would be to use `cargo build` 🤔
Also, what is the reason to use `--message-format=json`?
Finally, what is the `head` command for? I didn't see any obvious reason in
https://github.com/apache/datafusion/actions/runs/21890300850/job/63194519053
Perhaps you could add a comment explaining what those commands are for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
