kosiew commented on code in PR #20282:
URL: https://github.com/apache/datafusion/pull/20282#discussion_r2796689095
##########
.github/workflows/extended.yml:
##########
@@ -167,11 +167,18 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
+ - name: Build sqllogictest binary
+ run: |
+ TEST_BIN=$(cargo test --features backtrace,parquet_encryption
--profile release-nonlto --test sqllogictests --no-run --message-format=json |
sed -n 's/.*"executable":"\([^"]*\)".*/\1/p' | head -n 1)
Review Comment:
Thanks, good suggestions. I agree `cargo build` is clearer here since this
step only compiles the `sqllogictests` target and does not run it.
I used `--message-format=json` to capture the exact emitted test binary path
because Cargo places test executables under `target/.../deps` with a hash
suffix. The `head -n 1` was a simple way to select the first extracted
executable path from the stream.
I’ll simplify and document this more clearly in the workflow so the intent
is explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
