kosiew commented on code in PR #20282:
URL: https://github.com/apache/datafusion/pull/20282#discussion_r2796697231
##########
.github/workflows/extended.yml:
##########
@@ -167,11 +167,18 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
+ - name: Build sqllogictest binary
+ run: |
+ TEST_BIN=$(cargo test --features backtrace,parquet_encryption
--profile release-nonlto --test sqllogictests --no-run --message-format=json |
sed -n 's/.*"executable":"\([^"]*\)".*/\1/p' | head -n 1)
+ if [ -z "$TEST_BIN" ]; then
+ echo "Could not find sqllogictests test binary"
+ exit 1
+ fi
+ echo "TEST_BIN=$TEST_BIN" >> "$GITHUB_ENV"
- name: Run sqllogictest
run: |
- cargo test --features backtrace,parquet_encryption --profile
release-nonlto --test sqllogictests -- --include-sqlite
+ (
Review Comment:
The `cd` is needed because `sqllogictests` resolves test data via relative
paths (for example `test_files/` and `../../datafusion-testing/data/` in
`datafusion/sqllogictest/bin/sqllogictests.rs`), so running from repo root can
point it at the wrong locations. I added it after an earlier version without
`cd` errored with `test_files/` not found.
The subshell `(...)` was only used to scope `cd` so it would not affect the
subsequent `cargo clean`. It is not strictly necessary.
I’ll remove the subshell and switch to a cleaner step-level
`working-directory: datafusion/sqllogictest` for the test execution step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
