alamb commented on code in PR #20282:
URL: https://github.com/apache/datafusion/pull/20282#discussion_r2793991028
##########
.github/workflows/extended.yml:
##########
@@ -167,11 +167,18 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
+ - name: Build sqllogictest binary
+ run: |
+ TEST_BIN=$(cargo test --features backtrace,parquet_encryption
--profile release-nonlto --test sqllogictests --no-run --message-format=json |
sed -n 's/.*"executable":"\([^"]*\)".*/\1/p' | head -n 1)
+ if [ -z "$TEST_BIN" ]; then
+ echo "Could not find sqllogictests test binary"
+ exit 1
+ fi
+ echo "TEST_BIN=$TEST_BIN" >> "$GITHUB_ENV"
- name: Run sqllogictest
run: |
- cargo test --features backtrace,parquet_encryption --profile
release-nonlto --test sqllogictests -- --include-sqlite
+ (
Review Comment:
Why the `(` and `)`?
Also, why does it need to do `cd` when the current version doesn't?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
