kosiew commented on code in PR #20282:
URL: https://github.com/apache/datafusion/pull/20282#discussion_r2803523268
##########
.github/workflows/extended.yml:
##########
@@ -167,11 +167,19 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
+ - name: Build sqllogictest binary
+ run: |
+ # Cargo emits test binaries with hashed filenames under
target/.../deps.
+ # We use head to pick the first matching sqllogictests artifact from
the JSON stream.
+ TEST_BIN=$(cargo build --profile release-nonlto --features
backtrace,parquet_encryption --package datafusion-sqllogictest --test
sqllogictests --message-format=json | sed -n
's/.*"executable":"\([^"]*\)".*/\1/p' | head -n 1)
Review Comment:
Runs:
1. [cargo build, cargo
test](https://github.com/apache/datafusion/actions/runs/21983438928/job/63511596715?pr=20339)
<img width="928" height="85" alt="image"
src="https://github.com/user-attachments/assets/13dd113f-cd50-4801-a114-e45fa0e666f8";
/>
2. [cargo build, use binary build to run
test](https://github.com/apache/datafusion/actions/runs/21981129051/job/63503781240?pr=20335)
<img width="928" height="98" alt="image"
src="https://github.com/user-attachments/assets/711813c5-d692-4002-ac5f-d396e27ecf2a";
/>
3. [no cargo build, just cargo
test](https://github.com/apache/datafusion/actions/runs/21983537068/job/63511915154?pr=20338)
<img width="921" height="96" alt="image"
src="https://github.com/user-attachments/assets/4dc2b44f-e41e-47e8-a863-8ea03a81886c";
/>
From the above interim results, only the binary build test improves the CI
run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
