jcsherin commented on code in PR #11666:
URL: https://github.com/apache/datafusion/pull/11666#discussion_r1693945138
##########
datafusion/functions-aggregate/COMMENTS.md:
##########
@@ -54,7 +54,7 @@ first argument and the definition looks like this:
// `input_type` : data type of the first argument
let mut fields = vec![Field::new_list(
format_state_name(self.name(), "nth_value"),
- Field::new("item", args.input_type.clone(), true /* nullable of list item
*/ ),
+ Field::new("item", args.input_types.clone(), true /* nullable of list item
*/ ),
Review Comment:
Thanks @alamb for doing this 🙏.
The second argument should be `args.input_types[0].clone` according to the
changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
