jayzhan211 commented on PR #11666:
URL: https://github.com/apache/datafusion/pull/11666#issuecomment-2256183484
The end state in my mind now.
```rust
pub struct AccumulatorArgs<'a> {
/// Keep
pub data_type: &'a DataType,
/// We might only need one of `schema` or `dfschema`. It is likely we
keep `dfschema`, since we can get `schema` from it.
pub schema: &'a Schema,
pub dfschema: &'a DFSchema,
/// Keep
pub ignore_nulls: bool,
/// Convert to physical sort exprs instead
pub sort_exprs: &'a [Expr],
/// Keep
pub is_reversed: bool,
/// We might able to get the name from expressions
pub name: &'a str,
/// Keep
pub is_distinct: bool,
/// Get the type for schema and expressions
pub input_type: &'a DataType,
/// Convert to physical expressions
pub input_exprs: &'a [Expr],
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
