alamb commented on PR #11666:
URL: https://github.com/apache/datafusion/pull/11666#issuecomment-2256550294
> ```rust
> pub struct AccumulatorArgs<'a> {
> /// Keep, this is return type, the name might be quite confusing.
> pub data_type: &'a DataType,
I agree `return_type` would be clearer
>
> /// We might only need one of `schema` or `dfschema`. It is likely we
keep `dfschema`, since we can get `schema` from it.
I think `schema` is what makes sense as `dfschema` is mostly a logical thing
in my mind (as it has a relation name).
Further evidence that we don't need dfschema is that you can get a
`DataType` from a `PhysicalExpr` using a `Schema`
https://docs.rs/datafusion/latest/datafusion/physical_expr/trait.PhysicalExpr.html#tymethod.data_type
>
> /// Convert to physical sort exprs instead
> pub sort_exprs: &'a [Expr],
Agree
>
> /// Convert to physical expressions
> pub input_exprs: &'a [Expr],
> }
Make sense
Thanks @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
