jayzhan211 commented on PR #11666: URL: https://github.com/apache/datafusion/pull/11666#issuecomment-2255740888
> > I think we don't even need vector of input type, since we only get the first one. 🤔 > > Wouldn't we need a vector of input types if the aggregate had more than one argument? For example > > https://docs.rs/datafusion/latest/datafusion/functions_aggregate/approx_percentile_cont/fn.approx_percentile_cont.html Second argument is fixed type (f64), so we don't have the actual function that expect different multiple input type yet. Btw, I think we could remove `input_type`, because we could compute the type from `expr` and `schema`. If there are any UDAF expect more flexible accumulator based on input types, they can get the types from `expr` and `schema` too. Therefore, I recommend we remove input_type entirely and compute only if we need it in `create_accumulator` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
