jayzhan211 commented on PR #11666: URL: https://github.com/apache/datafusion/pull/11666#issuecomment-2256138991
> > Therefore, I suggest we remove input_type entirely and compute only if we need it in create_accumulator from input_exprs and schema. This not only make the code less confused and also let udaf be flexible and efficient (only compute types if needed) > > That certainly sounds cleaner. > > I feel like we have churned this API a bunch recently, so maybe we can take a step back and ensure that whatever we come up with supports the usecases we know of now (and in the future) so we don't keep changing it 🤔 I plan to change `input_exprs` to `physical-exprs` in #11359, so there will be another change. I think it would be nice to have something like `unstable feature` (maybe declare as part of the docs) similar to `nightly` in rust for feature or APIs that takes over one month (release cycle). After most of the things are done, we could consider it `stable` feature. We still do breaking change for `stable` feature, but it gives clear message to others about `unstable` feature that is in frequent changing stage, so there could be less impact on downstream, and also easier for developer to achieve the better design -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
