edmondop commented on PR #11013: URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2254253666
@jayzhan211 I am a little confused about the test case here https://github.com/apache/datafusion/blob/a721be1b1d863b5b15a7a945c37ec051c449c46f/datafusion/sqllogictest/test_files/aggregate.slt#L1779 I have noticed that in the signature for min/max as an AggregateFunction, TimeInterval is not added https://github.com/apache/datafusion/blob/a721be1b1d863b5b15a7a945c37ec051c449c46f/datafusion/expr/src/aggregate_function.rs#L119. If I don't add it, the SQL test fails because `arrow_type(min(c1))` returns `Utf8` for me, but if I add it then the query fails with error ```External error: query failed: DataFusion error: Internal error: Min/Max accumulator not implemented for type Interval(MonthDayNano).``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
