edmondop commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1699249210
##########
datafusion/expr/src/type_coercion/aggregates.rs:
##########
@@ -163,7 +142,7 @@ pub fn check_arg_count(
Ok(())
}
-fn get_min_max_result_type(input_types: &[DataType]) -> Result<Vec<DataType>> {
+pub fn get_min_max_result_type(input_types: &[DataType]) ->
Result<Vec<DataType>> {
Review Comment:
This was used from `coerce_types` and is now used from `coerce_types` within
the UDF implementation I can move it over to
https://github.com/apache/datafusion/pull/11013/files#diff-531ff673a571f9ab5fa3eaf24ea3d4d26385ba88cf33a1c47293d0a180c0d453
but the other are udfs (sum, etc) are still below in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
