milenkovicm commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4509671363
https://github.com/apache/datafusion/pull/22415#issuecomment-4508820929 > Right now nothing in DF actually uses apply_expressions so it does not fail. in version 54 is not used at all as @LiaCastaneda pointed out > So as of today, returning Ok(Continue) and skipping all expressions is actually safe. and implementors implementing `Ok(Continue)` are ok ? Its fine with me, i just want to understand whats the consequences of implementing `Ok(Continue)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
