adriangb commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4510575715
It's not that `Ok(Continue)` is undefined. It just means "this node contains no expressions". If the node contains expressions it is the wrong implementation. But of course if nothing is calling this implementation there will be no failures. If we did implement something that called this method what fails and how would depend on the implementation: if the implementation is calling `apply_expressions` and then downcasting to a specific expression type but the node had none of those expressions that won't cause an issue. But if it is e.g. looking for all `Column` references and the expression has columns but does not declare them via this API it's a ticking time bomb. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
