milenkovicm commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4510779815
> yes agreed hence why the plan was never to tell people "it is ok to leave Ok()" and the implementation forces users to implement it. > @milenkovicm suggested leaving `Ok()` (contradicting the current implementation and documentation) and I've been trying to help clarify why that would not cause issues today but would cause issues in the future as soon as this method starts being used, I did not mean to suggest all implementers should do that. point i was trying to make, if it is not used at the moment, having default implementation in the trait which returns whatever may be wrong but harmless. This way, the method remains available for experiments and users who need it can implement/override it themselves. It won’t force others to implement it just yet. Once it starts to be useful, (df 55, or later) default implementation can be removed forcing users to implement it, or it can quietly be removed without big impact if it proves to be not so useful anyway, its your call -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
