alamb commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4510120362
> I'm a bit confused how to handle df.54 upgrade, when it is safe to ignore it. I am also pretty confused. if we tell people "It is ok to leave Ok()" in your implementation (or add a default implementation) then aren't we leaving a time bomb for them if we do start using apply_expressions in the future? If we aren't using apply_expressions, I think we should remove it (and we can add it back in when we are actually going to use it). I can make a PR to do so -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
