alamb commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4511005412
> I think the point of "add a default implementation, even if unsafe so we can experiment and remove it once we plan to start using the method" is a really neat idea, I had not thought about it along those lines. It is a bit dangerous (someone could start using the method ignoring any comments or warnings) but pragmatically very useful. Let's keep it in mind when we add this back. I agree -- thank you for the idea @milenkovicm I still prefer we remove the unused code as i think it will avoid potential confusion (even if we added a default impl) The revert PR is here - https://github.com/apache/datafusion/pull/22437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
