alamb commented on code in PR #13717:
URL: https://github.com/apache/datafusion/pull/13717#discussion_r1884297250
##########
datafusion/core/src/catalog_common/information_schema.rs:
##########
@@ -406,6 +406,7 @@ fn get_udf_args_and_return_types(
.into_iter()
.map(|arg_types| {
// only handle the function which implemented
[`ScalarUDFImpl::return_type`] method
+ #[allow(deprecated)]
Review Comment:
> can we change the signature to `return_type(ReturnTypeArgs)` and remove
`return_type_with_args` at all
>
> I was thinking about this too but not sure this huge breaking change is
acceptable or not, but I think this will be a better change in long term
I agree `return_type(ReturnTypeArgs)` would be the best in the long term
However, in the short term (next 6 months) I think it would be nicer to
downstream crates / users to add a new function `return_type_with_args` and
leave `#deprecation` notices on `return_type` and `return_type_from_exprs`
directing people to `return_type_with_args`
Then once the deprecation period has passed we could rename / introduce a
new function called `return_type` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
