alamb commented on code in PR #13717:
URL: https://github.com/apache/datafusion/pull/13717#discussion_r1885065220
##########
datafusion/core/src/catalog_common/information_schema.rs:
##########
@@ -406,6 +406,7 @@ fn get_udf_args_and_return_types(
.into_iter()
.map(|arg_types| {
// only handle the function which implemented
[`ScalarUDFImpl::return_type`] method
+ #[allow(deprecated)]
Review Comment:
> But I guess for Comet, they need to switch to return_type_with_args first
for their fix and then switch back to return_type after a while.
Yes that is true and would be non ideal I agree
> Do you know who else rely on the return_type signature a lot and whether
this breaking change is a pain for them?
We use it a bunch in InfluxDB, eg
https://github.com/search?q=repo%3Ainfluxdata%2Finfluxdb3_core%20return_type&type=code
I expect anyone who has created user defined functions has implemented
`return_type` and thus will be impacted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
