jayzhan211 commented on code in PR #13717: URL: https://github.com/apache/datafusion/pull/13717#discussion_r1888525216
########## datafusion/core/src/catalog_common/information_schema.rs: ########## @@ -406,6 +406,7 @@ fn get_udf_args_and_return_types( .into_iter() .map(|arg_types| { // only handle the function which implemented [`ScalarUDFImpl::return_type`] method + #[allow(deprecated)] Review Comment: We want single return_type for cases in #13735 that only takes `arg_types` and compatible with other cases that takes 3 args, so we switch to `return_type_with_args` and deprecate `return_type_from_exprs ` and `return_type`. Any further changing of field won't cause signature change as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org