ccciudatu commented on code in PR #13772:
URL: https://github.com/apache/datafusion/pull/13772#discussion_r1897884798
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -438,6 +439,22 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
user_defined_literal.type_reference
)
}
+
+ fn consume_extension_table(
+ &self,
+ extension_table: &ExtensionTable,
+ _schema: &DFSchema,
+ _projection: &Option<MaskExpression>,
+ ) -> Result<LogicalPlan> {
Review Comment:
I can see your point, especially as I've been toying with the same idea
myself.
However, I found the intrinsic redundancy a bit error prone: at least in
theory, this interface allows the `ReadRel` to contain a table other than the
one passed in as the second argument.
Eliminating this redundancy would end up with the exact same signature as
`consume_read`, which renders the new helper(s) superfluous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
