findepi commented on code in PR #14366:
URL: https://github.com/apache/datafusion/pull/14366#discussion_r1934670024
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2420,19 +2420,24 @@ impl Window {
.iter()
.enumerate()
.filter_map(|(idx, expr)| {
- if let Expr::WindowFunction(WindowFunction {
+ let Expr::WindowFunction(window_func) = expr else {
+ return None;
+ };
+ let WindowFunction {
fun: WindowFunctionDefinition::WindowUDF(udwf),
partition_by,
..
- }) = expr
- {
- // When there is no PARTITION BY, row number will be unique
- // across the entire table.
- if udwf.name() == "row_number" && partition_by.is_empty() {
- return Some(idx + input_len);
- }
+ } = window_func.as_ref()
+ else {
+ return None;
+ };
+ // When there is no PARTITION BY, row number will be unique
+ // across the entire table.
+ if udwf.name() == "row_number" && partition_by.is_empty() {
+ return Some(idx + input_len);
+ } else {
+ None
Review Comment:
inconsistent return vs value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
