felipecrv commented on code in PR #14366:
URL: https://github.com/apache/datafusion/pull/14366#discussion_r1935630021
##########
datafusion/expr/src/expr.rs:
##########
@@ -297,7 +298,7 @@ pub enum Expr {
/// [`ExprFunctionExt`]: crate::expr_fn::ExprFunctionExt
AggregateFunction(AggregateFunction),
/// Represents the call of a window function with arguments.
- WindowFunction(WindowFunction),
+ WindowFunction(Box<WindowFunction>), // Boxed as it is large (272 bytes)
Review Comment:
```suggestion
WindowFunction(Box<WindowFunction>), // Boxed as it is large (> 272
bytes)
```
##########
datafusion/expr/src/expr.rs:
##########
@@ -297,7 +298,7 @@ pub enum Expr {
/// [`ExprFunctionExt`]: crate::expr_fn::ExprFunctionExt
AggregateFunction(AggregateFunction),
/// Represents the call of a window function with arguments.
- WindowFunction(WindowFunction),
+ WindowFunction(Box<WindowFunction>), // Boxed as it is large (272 bytes)
Review Comment:
```suggestion
WindowFunction(Box<WindowFunction>), // Boxed as it is large (>= 272
bytes)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
